Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1542 #1543

Merged
merged 8 commits into from
Apr 10, 2024
Merged

Issue1542 #1543

merged 8 commits into from
Apr 10, 2024

Conversation

BoPeng
Copy link
Contributor

@BoPeng BoPeng commented Apr 9, 2024

#1542

It looks like python 3.12 changes the calling pattern for multiple inheritance.

@gaow
Copy link
Member

gaow commented Apr 10, 2024

3.9 now failed the tests? It is insane how Python is updated so frequently and have all these compatibility issues! Even R does not do this to its users.

@BoPeng
Copy link
Contributor Author

BoPeng commented Apr 10, 2024

Yes, got python 3.10, 3.11, and 3.12 working, but 3.9 fails. The problem is that I used some private functions of pathlib in order to subclass pathlib.Path, and things got broken when this library was updated.

Let me see what is going on with 3.9.

@BoPeng
Copy link
Contributor Author

BoPeng commented Apr 10, 2024

The problem with python 3.9 is related to remote execution of tasks, which is quite puzzling, I do not have time to further investigate this issue and will leave it for later. You can make use of this branch if you are in a hurry.

@gaow
Copy link
Member

gaow commented Apr 10, 2024

Thank you @BoPeng . We typically use conda distributed packages to setup our containers automatically but for now we can try to install from this branch.

@gaow
Copy link
Member

gaow commented Apr 10, 2024

@BoPeng another idea is that we drop support ot python 3.9 and lower. We require it 3.10 and up?

@BoPeng BoPeng merged commit a511fa9 into master Apr 10, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants